[StorageCache] Adding Cluster Expansion spec 2026-01-01 #38843

Aman-Jain-14 · 2025-11-17T21:55:04Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

github-actions · 2025-11-17T21:55:17Z

Next Steps to Merge

Next steps that must be taken to merge this PR:

❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
This PR has ARMChangesRequested label. Please address or respond to feedback from the ARM API reviewer.
When you are ready to continue the ARM API review, please remove the ARMChangesRequested label.
Automation should then add WaitForARMFeedback label.
❗If you don't have permissions to remove the label, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories.
For details of the ARM review, see aka.ms/azsdk/pr-arm-review

Comment generated by summarize-checks workflow run.

github-actions · 2025-11-17T21:58:07Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language	API Review for Package
Swagger	Microsoft.StorageCache-StorageCache
Java	com.azure.resourcemanager:azure-resourcemanager-storagecachestoragecache
Go	sdk/resourcemanager/storagecache/armstoragecache

…e.md

mentat9 · 2025-11-25T00:35:13Z

/azp run

azure-pipelines · 2025-11-25T00:35:19Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

mentat9 · 2025-11-25T00:38:31Z

/azp run 'SDK Validation - .NET'

azure-pipelines · 2025-11-25T00:38:38Z

No pipelines are associated with this pull request.

mentat9 · 2025-11-25T00:50:29Z

/azp run

azure-pipelines · 2025-11-25T00:50:35Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

mentat9 · 2025-11-25T00:51:05Z

/azp run "SDK Validation - .NET"

mentat9 · 2025-11-25T00:51:10Z

/azp run

azure-pipelines · 2025-11-25T00:51:11Z

No pipelines are associated with this pull request.

azure-pipelines · 2025-11-25T00:51:17Z

You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list.

mentat9 · 2025-11-25T00:52:02Z

/azp run SDK Validation - .NET

azure-pipelines · 2025-11-25T00:52:12Z

Azure Pipelines successfully started running 1 pipeline(s).

Aman-Jain-14 · 2025-11-25T15:08:31Z

@mentat9 I looked at the error from the SDK pipeline but its stemming from a section of the spec that hasn't been changed for past 4 API releases. This is the specific error:

`azure-sdk-for-net/sdk/storagecache/Azure.ResourceManager.StorageCache/src/Customized/AmlFileSystemData.cs(43,47): error CS7036: There is no argument given that corresponds to the required parameter 'rootSquashSettings' of 'AmlFileSystemData.AmlFileSystemData(ResourceIdentifier, string, ResourceType, SystemData, IDictionary<string, string>, AzureLocation, ManagedServiceIdentity, StorageCacheSkuName, IList<string>, float?, float?, string, AmlFileSystemHealth, AmlFileSystemProvisioningStateType?, string, AmlFileSystemClientInfo, int?, AmlFileSystemEncryptionSettings, AmlFileSystemPropertiesMaintenanceWindow, AmlFileSystemPropertiesHsm, AmlFileSystemRootSquashSettings, IDictionary<string, BinaryData>)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/storagecache/Azure.ResourceManager.StorageCache/src/Azure.ResourceManager.StorageCache.csproj::TargetFramework=netstandard2.0]`

Since we are still using OpenAPI (and not Typespec), we rely on the manual process of getting our SDKs released. If this issue persists upon conversion to Typespec, we can investigate it further.

mentat9 · 2025-11-25T23:56:52Z

@Aman-Jain-14 - Please create a new PR with the correct baseline commit. New API version PRs should be constructed by:

Copy the current/latest API version spec to the new API version folder
Make a base commit
Apply changes for the new API version in subsequent commits
This allows reviewers to understand what is changing.

mentat9 · 2025-11-25T23:59:39Z

@mentat9 I looked at the error from the SDK pipeline but its stemming from a section of the spec that hasn't been changed for past 4 API releases. This is the specific error:

`azure-sdk-for-net/sdk/storagecache/Azure.ResourceManager.StorageCache/src/Customized/AmlFileSystemData.cs(43,47): error CS7036: There is no argument given that corresponds to the required parameter 'rootSquashSettings' of 'AmlFileSystemData.AmlFileSystemData(ResourceIdentifier, string, ResourceType, SystemData, IDictionary<string, string>, AzureLocation, ManagedServiceIdentity, StorageCacheSkuName, IList<string>, float?, float?, string, AmlFileSystemHealth, AmlFileSystemProvisioningStateType?, string, AmlFileSystemClientInfo, int?, AmlFileSystemEncryptionSettings, AmlFileSystemPropertiesMaintenanceWindow, AmlFileSystemPropertiesHsm, AmlFileSystemRootSquashSettings, IDictionary<string, BinaryData>)' [/mnt/vss/_work/1/s/azure-sdk-for-net/sdk/storagecache/Azure.ResourceManager.StorageCache/src/Azure.ResourceManager.StorageCache.csproj::TargetFramework=netstandard2.0]`

Since we are still using OpenAPI (and not Typespec), we rely on the manual process of getting our SDKs released. If this issue persists upon conversion to Typespec, we can investigate it further.

This seems like it could be an issue in the automation. See if it repros after you recreate the PR (per this comment: #38843 (comment)). If so, can you bring it to the attention of the SDK Team channel: https://teams.microsoft.com/l/channel/19%3A0351f5f9404446e4b4fd4eaf2c27448d%40thread.skype/API%20Spec%20Review?groupId=3e17dcb0-4257-4a30-b843-77f47f1d4121&tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47 and ask them for next steps?

…on_spec

Aman-Jain-14 · 2025-11-26T00:42:39Z

@mentat9 Here is the new PR: #38978

Closing this PR now.

[StorageCache] Adding Cluster Expansion spec 2026-01-01

2f07327

github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Nov 17, 2025

[StorageCache] Adding Cluster Expansion spec 2026-01-01 updated readm…

79e393d

…e.md

Aman-Jain-14 force-pushed the dev/amajai/main-add_2026_01_01_expansion_spec branch from ea8de62 to 79e393d Compare November 17, 2025 22:36

Aman Jain added 13 commits November 17, 2025 17:43

Updated readme.md to remove provider references

f5e14d9

Update relative paths to common-types in spec files

0f82991

Update relative paths to v2 common-types in spec files

be4884f

Update relative paths to v5 common-types in spec file

0c7cb81

Renaming exmaple files to match case

32cd36b

Adding files without expansion spec

d094482

Adding spec with correct API version

c668c00

Reverting spec version change for previous spec

07daf01

Adidng expansion spec

f86bb7a

Adding fixes from running prettier

b328f9b

Adding fixes from running prettier

a808179

Fixing linter errors

920a4be

Removing redundant fields from properties

d0d0086

Aman-Jain-14 requested a review from brpanask November 24, 2025 14:26

mentat9 added the ARMChangesRequested label Nov 25, 2025

github-actions bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Nov 25, 2025

Merge branch 'Azure:main' into dev/amajai/main-add_2026_01_01_expansi…

a1e4d5a

…on_spec

Aman-Jain-14 closed this Nov 26, 2025

[StorageCache] Adding Cluster Expansion spec 2026-01-01 #38843

[StorageCache] Adding Cluster Expansion spec 2026-01-01 #38843

Uh oh!

Conversation

Aman-Jain-14 commented Nov 17, 2025

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

github-actions bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

github-actions bot commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Change Check

Uh oh!

mentat9 commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

mentat9 commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

mentat9 commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

mentat9 commented Nov 25, 2025

Uh oh!

mentat9 commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

mentat9 commented Nov 25, 2025

Uh oh!

azure-pipelines bot commented Nov 25, 2025

Uh oh!

Aman-Jain-14 commented Nov 25, 2025

Uh oh!

mentat9 commented Nov 25, 2025

Uh oh!

mentat9 commented Nov 25, 2025

Uh oh!

Aman-Jain-14 commented Nov 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions bot commented Nov 17, 2025 •

edited

Loading

github-actions bot commented Nov 17, 2025 •

edited

Loading